fix #23043 #23044
Open
fix #23043 #23044
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rssh
force-pushed
the
invalid_naming_2025_04_24_fix
branch
from
cd2f10c to
fb1272c
Compare
If this gets included in Scala 3.7.2, then it'd be assessed for a potential LTS backport to 3.3.7, if I count right. |
|
oops, -- path need more investigation. (just receive same test fail again with it) |
|
Checked that last commit at least fixed our case. [and it's more compliant with 1-st condition about preexisting.definedInCurrentRun || preexisting.lastKnownDenotation.is(Package) ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure, that this is not a hiding a sympthome, maybe we should instead research, why preExisting.associatedFile == null
Btw, it will be good to see this backported into LTS.