Skip to content

Reviewer suggestion (#4787) E2E tests to add #10993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
9 tasks done
touhidurabir opened this issue Feb 27, 2025 · 6 comments
Open
9 tasks done

Reviewer suggestion (#4787) E2E tests to add #10993

touhidurabir opened this issue Feb 27, 2025 · 6 comments
Assignees
@touhidurabir
Labels
Housekeeping:2:Urgent Any dependency management or refactor that must be done soon to fix or avoid a significant problem.
Milestone
3.5 Internal

Comments

@touhidurabir
Copy link
Member

touhidurabir commented Feb 27, 2025 •
edited
Loading

Description:
With the merge of #4787, now it's possible to add reviewer suggestion for a submission in OJS/OMP . As this feature add a lot of cases and introduce several new options in workflow, need to add comprehensive cypress tests for this which include

  • Enable/Disable reviewer suggestion in settings and impact on submission wizard
  • Add/Edit/Delete reviewer suggestions along with validation
  • Enable/Disable reviewer suggestion in settings which impact the visibility to suggested reviewers in submission and review (only external review stage for OMP) stage
  • Confirm/Approve a suggested reviewer that does not exists from Add Reviewer modal and right side panel
  • Confirm/Approve a suggested reviewer that does exists as user with reviewer role from Add Reviewer modal and right side panel
  • Confirm/Approve a suggested reviewer that does exists as user but without reviewer role from Add Reviewer modal and right side panel
  • Add a reviewer via Add Reviewer modal from the list of pre existing reviewers which match a suggested reviewer and it's impact .
  • Create a new reviewer from Add Reviewer modal which match a suggested reviewer and it's impact .
  • Enroll existing user that match reviewer suggestion

What application are you using?
OJS, OMP or OPS version 3.5 and main

PRs

Stable-3.5.0

pkp-lib --> #11054
ui-library --> pkp/ui-library#554
ojs --> pkp/ojs#4726
omp --> pkp/omp#1885
ops --> pkp/ops#966 [TEST ONLY]

main

pkp-lib --> #11056
ui-library --> pkp/ui-library#555
ojs --> pkp/ojs#4727
omp --> pkp/omp#1890
@touhidurabir touhidurabir self-assigned this Feb 27, 2025
@touhidurabir touhidurabir added this to the 3.5 Internal milestone Feb 27, 2025
@touhidurabir touhidurabir added the Housekeeping:2:Urgent Any dependency management or refactor that must be done soon to fix or avoid a significant problem. label Feb 27, 2025
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
5d34242
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
362a3d6
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 10, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
5fbde91
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 10, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
bc3b507
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
cbcc4cd
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
adc0442
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
a5f3f06
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
7bc6684
This was referenced Mar 10, 2025
Open
Open
Open
@touhidurabir touhidurabir linked a pull request Mar 10, 2025 that will close this issue
pkp/pkp-lib#10993 Reviewer Suggestion E2E test pkp/ui-library#554
Open
@touhidurabir touhidurabir removed a link to a pull request Mar 10, 2025
pkp/pkp-lib#10993 Reviewer Suggestion E2E test pkp/ui-library#554
Open
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 updated data suit test data
e53e7e6
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
a51a6d6
touhidurabir added a commit to touhidurabir/omp that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
ed56ccd
@touhidurabir touhidurabir mentioned this issue Mar 10, 2025
Open
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Mar 10, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
08a0822
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
a5d7e90
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
e8e946f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
d7d599f
This was referenced Mar 10, 2025
Open
Open
Open
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Mar 10, 2025
@touhidurabir
pkp/pkp-lib#10993 moved reviewer suggestion enable to before action
e63efdc
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 update test
9dc5dad
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
9ccd0fb
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
63c4e0c 
pkp/pkp-lib#10993 update test conditions

pkp/pkp-lib#10993 update test

pkp/pkp-lib#10993 test update
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
979c08b 
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
touhidurabir added a commit to touhidurabir/ops that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_stable_3_5_0##
8d14dae
@touhidurabir touhidurabir mentioned this issue Apr 23, 2025
Open
touhidurabir added a commit to touhidurabir/ui-library that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
2de2de4
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Apr 23, 2025
@touhidurabir
pkp#10993 command update
90635cc
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Apr 23, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
bd039db
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Apr 23, 2025
@touhidurabir
pkp#10993 command update
b0520b4
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Apr 23, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
fda50f7 
pkp#10993 command update
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 test update
5f4608f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
3581350
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
e2e7113 
pkp/pkp-lib#10993 test update
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
26360f0 
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 test update
95f8b17
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer Suggestion E2E test
5753d70 
pkp/pkp-lib#10993 test update

pkp/pkp-lib#10993 test update
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
77d2fcc 
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 test update
f3a8c00
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
274ac28
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer suggestion E2E test
9ab33a1
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
5acddfd
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 test update
3437180
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Reviewer suggestion E2E test
bb9f299 
pkp/pkp-lib#10993 test update
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 23, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
9cce3fe
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Apr 24, 2025
@touhidurabir
pkp#10993 command update
0d5880d
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Apr 24, 2025
@touhidurabir
pkp#10993 Reviewer Suggestion E2E test
2ae3927 
pkp#10993 command update

pkp#10993 command update
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 24, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
4988aec 
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##

pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 24, 2025
@touhidurabir
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
de60747 
pkp/pkp-lib#10993 Submodule Update ##touhidurabir/i10993_main##
@touhidurabir
Copy link
Member Author

Hi @Hafsa-Naeem , I have addressed your points and need approval to stable-3.5.0 branch to merge the changes .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

Labels
Housekeeping:2:Urgent Any dependency management or refactor that must be done soon to fix or avoid a significant problem.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
3 participants
@withanage @touhidurabir @Hafsa-Naeem