fix(cli): convert Windows absolute paths to file URLs for dynamic imports #7126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic import in `importAlterationScript` was failing on Windows because it used an absolute file path without converting it to a valid file URL.
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/cli/src/commands/database/alteration/index.ts | 📈 +57 Bytes |
|
Hi, there's actually a typo in the commit message, as the CI complains right now. The commit scope should be |
Sure thing! |
jtmaveryk
changed the title
|
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(cli): convert Windows absolute paths to file URLs for dynamic imports
The dynamic import in
importAlterationScriptwas failing on Windows because it used an absolute file path without converting it to a valid file URL. This commit updates the code to usepathToFileURLfor converting file paths, resolving the ERR_UNSUPPORTED_ESM_URL_SCHEME error during database alteration deployment.Summary
This change fixes a bug where dynamic imports were failing on Windows due to the use of absolute file paths without the proper
file://scheme. By converting these paths using Node'spathToFileURL, the error is resolved and the deployment process works consistently across platforms.Testing
Tested on Windows by running the
logto db alt deploycommand with a sample database URL. Verified that the alterations deploy successfully without triggering the ERR_UNSUPPORTED_ESM_URL_SCHEME error, and confirmed that existing unit tests pass.Checklist
.changeset