Skip to content

stop publishing debian7 and debian8 from 1.23.7 onwards #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 10, 2025

Closes #509

See

image

@v1v v1v requested review from a team as code owners February 10, 2025 22:02
Copy link

mergify bot commented Feb 10, 2025

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d is the label to automatically backport to the 1./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmacknz
Copy link
Member

cmacknz commented Feb 11, 2025

You can get rid of debian8 for sure. 7.17 still references debian 7 but not 8 which is strange.

https://github.com/elastic/beats/blob/a69b50616b084595917635529e21901a44ed0171/dev-tools/mage/crossbuild.go#L196-L234

Let me look into if we still need this as the support matrix has been updated since those changes.

Main and 8.x are all using Debian 11.

@cmacknz
Copy link
Member

cmacknz commented Feb 11, 2025

The Linux case selecting Debian 7 is the problematic one.

	case strings.HasPrefix(platform, "linux"):
		// Use an older version of libc to gain greater OS compatibility.
		// Debian 7 uses glibc 2.13.
		tagSuffix = "main-debian7"
	}

@v1v
Copy link
Member Author

v1v commented Feb 11, 2025

Thanks for double checking, I missed the Debian 7 in 7.17, phew.

I'll change the scope for Debian 8 in this PR for now, and then we can figure out if Debian7 in a follow-up


@cmacknz
Copy link
Member

cmacknz commented Feb 11, 2025

From https://www.elastic.co/support/matrix

Several Beats like Packetbeat, Heartbeat, and Auditbeat claim to support Debian 8 in 7.17 with no footnotes.

For Filebeat and Metricbeat there is a footnote that we only support Debian 10 and above.

So we potentially can remove Debian 7 assuming it doesn't break compatibility with the glibc in the older RHEL releases we support. Or we can wait until 7.17.x goes EOL and do a larger removal of lots of things.

@v1v
Copy link
Member Author

v1v commented Feb 11, 2025

Although 7.17 is based on 1.22 instead of 1.23, my plan was to do that from 1.23 onwards.

Do we plan to support 1.23 in 7.17?

@v1v
Copy link
Member Author

v1v commented Feb 11, 2025

So we potentially can remove Debian 7 assuming it doesn't break compatibility with the glibc in the older RHEL releases we support. Or we can wait until 7.17.x goes EOL and do a larger removal of lots of things.

I wanted to take the opportunity to remove them before 1.24 is released, so thinking the next patch for 1.23 was a good opportunity.

No rush in what we decide to do here.

We can wait for 1.24 and remove Debian 7 and Debian 8 for that Golang version - 1.24.0 is expected to be released in the upcoming weeks.

@cmacknz
Copy link
Member

cmacknz commented Feb 11, 2025

We will probably leave 7.17 at 1.22 so that makes sense to me.

@v1v
Copy link
Member Author

v1v commented Feb 11, 2025

We will probably leave 7.17 at 1.22 so that makes sense to me.

Great, we have a plan, I'll merge this PR as is then - only after your review please

@v1v v1v requested a review from cmacknz February 11, 2025 17:05
@v1v v1v self-assigned this Feb 11, 2025
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@v1v v1v merged commit 3caff4e into elastic:main Feb 11, 2025
10 checks passed
v1v added a commit that referenced this pull request Feb 11, 2025
…actions-2

* upstream/main:
  stop publishing debian7 and debian8 from 1.23.7 onwards (#510)
  ci(buildkite): let the robots team to run builds through the UI (#511)
  docs: update references for ppc (#513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop building debian7 and debian8
4 participants