Skip to content

Exclude dotted indices from settings pull #43306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2025
Merged

Exclude dotted indices from settings pull #43306

merged 2 commits into from
Mar 16, 2025

Conversation

3kt
Copy link
Contributor

@3kt 3kt commented Mar 15, 2025

Proposed commit message

"Actually" prevents system indices from being pulled by the _settings API call. The wildcard expansion requires dotted indices to be explicitly excluded.

Follow-up to #43243

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 15, 2025
@mergify mergify bot assigned 3kt Mar 15, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 15, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @3kt? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@3kt 3kt added Team:Monitoring Stack Monitoring team backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Mar 16, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 16, 2025
@3kt 3kt marked this pull request as ready for review March 16, 2025 16:15
@3kt 3kt requested a review from a team as a code owner March 16, 2025 16:15
consulthys
consulthys approved these changes Mar 16, 2025
View reviewed changes
Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

@3kt 3kt merged commit f402559 into elastic:main Mar 16, 2025
34 checks passed
@3kt 3kt deleted the elasticsearch_integration_no_hit_system_indices branch March 16, 2025 16:23
mergify bot pushed a commit that referenced this pull request Mar 16, 2025
@3kt @mergify
Exclude dotted indices from settings pull (#43306)
14a60a1 
* Exclude dotted indices from settings pull

* Added changelog entry

(cherry picked from commit f402559)

# Conflicts:
#	metricbeat/module/elasticsearch/index/data.go
@mergify mergify bot mentioned this pull request Mar 16, 2025
Merged
mergify bot pushed a commit that referenced this pull request Mar 16, 2025
@3kt @mergify
Exclude dotted indices from settings pull (#43306)
9d7f788 
* Exclude dotted indices from settings pull

* Added changelog entry

(cherry picked from commit f402559)

# Conflicts:
#	metricbeat/module/elasticsearch/index/data.go
@mergify mergify bot mentioned this pull request Mar 16, 2025
Closed
3kt added a commit that referenced this pull request Mar 25, 2025
@mergify @3kt
[8.x](backport #43306) Exclude dotted indices from settings pull (#43307
55f9766 
)

* Exclude dotted indices from settings pull (#43306)

* Exclude dotted indices from settings pull

* Added changelog entry

(cherry picked from commit f402559)

# Conflicts:
#	metricbeat/module/elasticsearch/index/data.go

* Resolved conflict

---------

Co-authored-by: Alexis Charveriat <alcharveriat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consulthys consulthys consulthys approved these changes

Assignees

@3kt 3kt

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch Team:Monitoring Stack Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3kt @consulthys