Skip to content

Remove direct dependency on Azure/go-autorest/autorest/adal #42959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 26, 2025
Merged

Remove direct dependency on Azure/go-autorest/autorest/adal #42959

merged 7 commits into from
Mar 26, 2025

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Feb 28, 2025 •
edited
Loading

Proposed commit message

Remove direct dependency on Azure/go-autorest/autorest/adal

Remove direct use of the deprecated autorest/adal, replacing it with
azidentity, as described in the migration guide[1].

Indirect dependencies remain:

- github.com/elastic/beats/v7/x-pack/filebeat/input/o365audit
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/filebeat/input/azureeventhub
  - github.com/Azure/azure-event-hubs-go/v3/storage
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/metricbeat/module/azure/app_insights
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

[1]: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/MIGRATION.md

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@chrisberkhout chrisberkhout self-assigned this Feb 28, 2025
@chrisberkhout chrisberkhout requested review from a team as code owners February 28, 2025 10:54
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 28, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @chrisberkhout? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@chrisberkhout chrisberkhout added the Team:Security-Service Integrations Security Service Integrations Team label Feb 28, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 28, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@chrisberkhout chrisberkhout mentioned this pull request Feb 28, 2025
Open
@efd6 efd6 added backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Mar 2, 2025
efd6
efd6 reviewed Mar 2, 2025
View reviewed changes
@chrisberkhout chrisberkhout force-pushed the remove-autorest-adal branch from 878efb6 to 4673d4c Compare March 3, 2025 16:32
@chrisberkhout chrisberkhout requested a review from efd6 March 3, 2025 16:32
@chrisberkhout chrisberkhout force-pushed the remove-autorest-adal branch from 4673d4c to bf268e5 Compare March 4, 2025 09:15
@chrisberkhout chrisberkhout enabled auto-merge (squash) March 4, 2025 09:16
@chrisberkhout chrisberkhout disabled auto-merge March 4, 2025 09:46
@chrisberkhout chrisberkhout enabled auto-merge (squash) March 24, 2025 12:15
@chrisberkhout chrisberkhout merged commit a2c36f5 into elastic:main Mar 26, 2025
149 of 152 checks passed
mergify bot pushed a commit that referenced this pull request Mar 26, 2025
@chrisberkhout @mergify
Remove direct dependency on Azure/go-autorest/autorest/adal (#42959)
81cf068 
Remove direct use of the deprecated autorest/adal, replacing it with
azidentity, as described in the migration guide[1].

Indirect dependencies remain:

- github.com/elastic/beats/v7/x-pack/filebeat/input/o365audit
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/filebeat/input/azureeventhub
  - github.com/Azure/azure-event-hubs-go/v3/storage
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/metricbeat/module/azure/app_insights
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

[1]: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/MIGRATION.md

(cherry picked from commit a2c36f5)
mergify bot pushed a commit that referenced this pull request Mar 26, 2025
@chrisberkhout @mergify
Remove direct dependency on Azure/go-autorest/autorest/adal (#42959)
1a43607 
Remove direct use of the deprecated autorest/adal, replacing it with
azidentity, as described in the migration guide[1].

Indirect dependencies remain:

- github.com/elastic/beats/v7/x-pack/filebeat/input/o365audit
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/filebeat/input/azureeventhub
  - github.com/Azure/azure-event-hubs-go/v3/storage
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/metricbeat/module/azure/app_insights
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

[1]: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/MIGRATION.md

(cherry picked from commit a2c36f5)
This was referenced Mar 26, 2025
Merged
Merged
chrisberkhout added a commit that referenced this pull request Mar 26, 2025
@chrisberkhout
Remove direct dependency on Azure/go-autorest/autorest/adal (#42959)
ca76463 
Remove direct use of the deprecated autorest/adal, replacing it with
azidentity, as described in the migration guide[1].

Indirect dependencies remain:

- github.com/elastic/beats/v7/x-pack/filebeat/input/o365audit
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/filebeat/input/azureeventhub
  - github.com/Azure/azure-event-hubs-go/v3/storage
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/metricbeat/module/azure/app_insights
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

[1]: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/MIGRATION.md

(cherry picked from commit a2c36f5)
chrisberkhout added a commit that referenced this pull request Mar 27, 2025
@mergify @chrisberkhout
Remove direct dependency on Azure/go-autorest/autorest/adal (#42959) (#…
7bccb2b 
…43504)

Remove direct use of the deprecated autorest/adal, replacing it with
azidentity, as described in the migration guide[1].

Indirect dependencies remain:

- github.com/elastic/beats/v7/x-pack/filebeat/input/o365audit
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/filebeat/input/azureeventhub
  - github.com/Azure/azure-event-hubs-go/v3/storage
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/metricbeat/module/azure/app_insights
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

[1]: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/MIGRATION.md

(cherry picked from commit a2c36f5)

Co-authored-by: Chris Berkhout <chris.berkhout@elastic.co>
chrisberkhout added a commit that referenced this pull request Apr 17, 2025
@mergify @chrisberkhout
Remove direct dependency on Azure/go-autorest/autorest/adal (#42959) (#…
0079ec4 
…43505)

Remove direct use of the deprecated autorest/adal, replacing it with
azidentity, as described in the migration guide[1].

Indirect dependencies remain:

- github.com/elastic/beats/v7/x-pack/filebeat/input/o365audit
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/filebeat/input/azureeventhub
  - github.com/Azure/azure-event-hubs-go/v3/storage
    - github.com/Azure/go-autorest/autorest/adal

- github.com/elastic/beats/v7/x-pack/metricbeat/module/azure/app_insights
  - github.com/Azure/go-autorest/autorest
    - github.com/Azure/go-autorest/autorest/adal

[1]: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/MIGRATION.md

(cherry picked from commit a2c36f5)

Co-authored-by: Chris Berkhout <chris.berkhout@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@efd6 efd6 efd6 approved these changes

Assignees

@chrisberkhout chrisberkhout

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch cleanup Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisberkhout @elasticmachine @andrewkroh @efd6