Skip to content

[Stack Monitoring] Remove kibana.settings metricset #42937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2025
Merged

[Stack Monitoring] Remove kibana.settings metricset #42937

merged 2 commits into from
Feb 27, 2025

Conversation

consulthys
Copy link
Contributor

Proposed commit message

This PR removes the kibana.settings metric set as requested in #30592 since the settings API was removed from Kibana in 8.0. There are no reasons to keep that module around.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

There is no impact since the kibana.settings metric set is not working anyway.

How to test this PR locally

Try to run Metricbeat with the kibana module and the settings metricset enabled and verify that it fails to run.

Related issues

Fixes #30592

@consulthys consulthys added Feature:Stack Monitoring Module:kibana Kibana Beats modules Team:Monitoring Stack Monitoring team backport-9.0 Automated backport to the 9.0 branch labels Feb 27, 2025
@consulthys consulthys self-assigned this Feb 27, 2025
@consulthys consulthys requested review from a team as code owners February 27, 2025 08:54
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 27, 2025
@consulthys consulthys mentioned this pull request Feb 27, 2025
Closed
@consulthys consulthys requested a review from pickypg February 27, 2025 10:13
@consulthys consulthys merged commit 1ff5c49 into main Feb 27, 2025
34 checks passed
@consulthys consulthys deleted the stack-mon-kibana-settings-30592 branch February 27, 2025 18:25
mergify bot pushed a commit that referenced this pull request Feb 27, 2025
@consulthys @mergify
[Stack Monitoring] Remove kibana.settings metricset (#42937)
556d149 
* Remove kibana.settings metricset

(cherry picked from commit 1ff5c49)
@mergify mergify bot mentioned this pull request Feb 27, 2025
Merged
5 tasks
consulthys added a commit that referenced this pull request Feb 27, 2025
@mergify @consulthys
[Stack Monitoring] Remove kibana.settings metricset (#42937) (#42952)
91b3d54 
* Remove kibana.settings metricset

(cherry picked from commit 1ff5c49)

Co-authored-by: Valentin Crettaz <valentin.crettaz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickypg pickypg pickypg approved these changes

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@consulthys consulthys

Labels
backport-9.0 Automated backport to the 9.0 branch Feature:Stack Monitoring Module:kibana Kibana Beats modules Team:Monitoring Stack Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metricbeat] remove kibana.settings metricset
3 participants
@consulthys @pickypg @VihasMakwana