Skip to content

Add status reporting for Journald input #42462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

Add status reporting for Journald input #42462

merged 2 commits into from
Jan 31, 2025

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Jan 28, 2025 •
edited
Loading

Proposed commit message

This commit adds the status reporting for the Journald input. It also adds a debug log to the UpdateStatus function from v2.Context.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Disruptive User Impact
## Author's Checklist

How to test this PR locally

  1. Build the Elastic-Agent with Beats from this PR or build Agent beat and replace its binary in a existing Elastic-Agent installation
  2. Create a policy with "Custom Journald logs" or add the integration to an existing policy
  3. Set the log level to debug
  4. Deploy/Restart the Elastic-Agent
  5. Look for the debug messages from the logger input.journald:
    • updating status, status: 'Starting', message: 'Starting'
    • updating status, status: 'Running', message: 'Running'
  6. Ensure the Journald integration for your Elastic-Agent shows the status Healthy

Related issues

## Use cases
## Screenshots
## Logs

@belimawr belimawr added skip-ci Skip the build in the CI but linting Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team skip docs-build Skips docs build CI labels Jan 28, 2025
@belimawr belimawr self-assigned this Jan 28, 2025
@belimawr belimawr requested a review from a team as a code owner January 28, 2025 18:30
@belimawr belimawr requested review from rdner and mauri870 January 28, 2025 18:30
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 28, 2025
@belimawr belimawr added needs_team Indicates that the issue/PR needs a Team:* label backport-8.x Automated backport to the 8.x branch with mergify labels Jan 28, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 28, 2025
@belimawr belimawr force-pushed the 39791-journald-status-reporting branch from 43be8b4 to 9c98d03 Compare January 28, 2025 18:31
@belimawr belimawr removed skip-ci Skip the build in the CI but linting skip docs-build Skips docs build CI labels Jan 28, 2025
@belimawr
Add status reporting for Journald input
5f7b22f 
This commit adds the status reporting for the Journald input. It also
adds a debug log to the `UpdateStatus` function from `v2.Context`.
@belimawr belimawr force-pushed the 39791-journald-status-reporting branch from 9c98d03 to 5f7b22f Compare January 28, 2025 18:33
@belimawr
Rename method receiver
50f770c 
Rename method receiver to fix lint warnings
mauri870
mauri870 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good. I did not test it locally. Please let me know if you require someone to do that.

@belimawr belimawr merged commit 76f4086 into elastic:main Jan 31, 2025
31 checks passed
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@belimawr @mergify
Add status reporting for Journald input (#42462)
8c6b2d3 
This commit adds the status reporting for the Journald input. It also
adds a debug log to the `UpdateStatus` function from `v2.Context`.

(cherry picked from commit 76f4086)
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
6 tasks
@cmacknz
Copy link
Member

cmacknz commented Jan 31, 2025

This needs to go in the 8.18 branch

@cmacknz cmacknz added the backport-8.18 Automated backport to the 8.18 branch label Jan 31, 2025
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@belimawr @mergify
Add status reporting for Journald input (#42462)
2595db9 
This commit adds the status reporting for the Journald input. It also
adds a debug log to the `UpdateStatus` function from `v2.Context`.

(cherry picked from commit 76f4086)
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
6 tasks
belimawr added a commit that referenced this pull request Feb 3, 2025
@mergify @belimawr
Add status reporting for Journald input (#42462) (#42561)
aa39888 
This commit adds the status reporting for the Journald input. It also
adds a debug log to the `UpdateStatus` function from `v2.Context`.

(cherry picked from commit 76f4086)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
belimawr added a commit that referenced this pull request Feb 3, 2025
@mergify @belimawr
Add status reporting for Journald input (#42462) (#42538)
9d1b27c 
This commit adds the status reporting for the Journald input. It also
adds a debug log to the `UpdateStatus` function from `v2.Context`.

(cherry picked from commit 76f4086)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauri870 mauri870 mauri870 approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@belimawr belimawr

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Journald] Implement status reporting for Elastic-Agent
4 participants
@belimawr @elasticmachine @cmacknz @mauri870