libbeat/processors/replace: fix zero string replacement validation #40751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Filebeat
botelastic
bot
added
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
|
|
mergify
bot
added
the
backport-8.x
4 tasks
|
/test |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
belimawr
approved these changes
Sep 12, 2024
efd6
commented
Sep 12, 2024
| @@ -162,6 +162,7 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff] | |||
| - Fix credential handling when workload identity is being used in GCS input. {issue}39977[39977] {pull}40663[40663] | |||
| - Fix publication of group data from the Okta entity analytics provider. {pull}40681[40681] | |||
| - Ensure netflow custom field configuration is applied. {issue}40735[40735] {pull}40730[40730] | |||
| - Fix replace processor handling of zero string replacement validation. {pull}[] | |||
Merged
6 tasks
6 tasks
6 tasks
efd6
added a commit
that referenced
this pull request
Sep 13, 2024
…placement validation (#40801) * libbeat/processors/replace: fix zero string replacement validation (#40751) The change in #40047 breaks the use of the replace processor to do s/<pattern>// replacement. So make the validation on absence, not zero state. (cherry picked from commit a45a3ac) * add missing pr number --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Merged
6 tasks
efd6
added a commit
that referenced
this pull request
Sep 20, 2024
…eplacement validation (#40917) * libbeat/processors/replace: fix zero string replacement validation (#40751) The change in #40047 breaks the use of the replace processor to do s/<pattern>// replacement. So make the validation on absence, not zero state. (cherry picked from commit a45a3ac) * add missing pr number --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The change in #40047 breaks the use of the replace processor to do
s/<pattern>//replacement. So make the validation on absence, not zero state.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs