V3 Work #48
Draft
V3 Work #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 32 out of 51 changed files in this pull request and generated 2 comments.
Files not reviewed (19)
- src/ACL/ACLAuthMethod.php: Language not supported
- src/ACL/ACLAuthMethodListEntry.php: Language not supported
- src/ACL/ACLAuthMethodListEntryQueryResponse.php: Language not supported
- src/ACL/ACLAuthMethodNamespaceRule.php: Language not supported
- src/ACL/ACLAuthMethodQueryResponse.php: Language not supported
- src/ACL/ACLAuthMethodWriteResponse.php: Language not supported
- src/ACL/ACLBindingRule.php: Language not supported
- src/ACL/ACLBindingRuleQueryResponse.php: Language not supported
- src/ACL/ACLBindingRuleWriteResponse.php: Language not supported
- src/ACL/ACLBindingRulesQueryResponse.php: Language not supported
- src/ACL/ACLClient.php: Language not supported
- src/ACL/ACLEntriesResponse.php: Language not supported
- src/ACL/ACLEntry.php: Language not supported
- src/ACL/ACLLink.php: Language not supported
- src/ACL/ACLLoginParams.php: Language not supported
- src/ACL/ACLNodeIdentity.php: Language not supported
- src/ACL/ACLOIDCAuthURLParams.php: Language not supported
- src/ACL/ACLOIDCCallbackParams.php: Language not supported
- src/ACL/ACLPolicy.php: Language not supported
Comments suppressed due to low confidence (1)
README.md:106
- There appears to be an extra closing bracket in the client instantiation, which may lead to a syntax error in the example code. Consider removing the extra bracket.
$proxyClient = new \GuzzleHttp\Client(['proxy' => 'whatever proxy you want']]);
There was a problem hiding this comment.
Copilot reviewed 41 out of 60 changed files in this pull request and generated 1 comment.
Files not reviewed (19)
- src/ACL/ACLAuthMethod.php: Language not supported
- src/ACL/ACLAuthMethodListEntry.php: Language not supported
- src/ACL/ACLAuthMethodListEntryQueryResponse.php: Language not supported
- src/ACL/ACLAuthMethodNamespaceRule.php: Language not supported
- src/ACL/ACLAuthMethodQueryResponse.php: Language not supported
- src/ACL/ACLAuthMethodWriteResponse.php: Language not supported
- src/ACL/ACLBindingRule.php: Language not supported
- src/ACL/ACLBindingRuleQueryResponse.php: Language not supported
- src/ACL/ACLBindingRuleWriteResponse.php: Language not supported
- src/ACL/ACLBindingRulesQueryResponse.php: Language not supported
- src/ACL/ACLClient.php: Language not supported
- src/ACL/ACLEntriesResponse.php: Language not supported
- src/ACL/ACLEntry.php: Language not supported
- src/ACL/ACLLink.php: Language not supported
- src/ACL/ACLLoginParams.php: Language not supported
- src/ACL/ACLNodeIdentity.php: Language not supported
- src/ACL/ACLOIDCAuthURLParams.php: Language not supported
- src/ACL/ACLOIDCCallbackParams.php: Language not supported
- src/ACL/ACLPolicy.php: Language not supported
Comments suppressed due to low confidence (1)
README.md:106
- An extra closing bracket appears in the instantiation of \GuzzleHttp\Client, which may result in a syntax error. Please remove the additional bracket.
$proxyClient = new \GuzzleHttp\Client(['proxy' => 'whatever proxy you want']]);
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Daniel Carbone <daniel.p.carbone@gmail.com>
… another FakeMap impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
FakeMapclass.FakeSliceclass.ScalarTypeinterface.Transcodingtype and usage.UnmarshallerandMarshallertraits and flow.Time\Durationvalues to acceptnull|int|float|string|\DateInterval|Time\Durationfor construction.enumtypes for enum values.