Add option to remove unique token #497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,6 +57,10 @@ defmodule Exq.Redis.JobQueue do | |||
| end | |||
| end | |||
|
|
|||
| def unlock_jobs(redis, namespace, raw_jobs) do | |||
| raw_jobs |> Enum.each(&unlock(redis, namespace, Job.decode(&1).unique_token)) | |||
There was a problem hiding this comment.
Should we handle missing unique_token gracefully? Let's say we enable this flag by default on ExqUI, it's easier to just send a list of jobs and include this flag rather than trying to figure out which job has unique token etc. If there is no token, this could become a no-op?
|
lgtm overall, I will test it a bit more and plan to merge this weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this issue Addition of
unlockoption toremove_*_jobsfunctions family