Skip to content

Fix 404 documentation links and improve PR labeling rules (#3269, #3273) #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kutumia
Copy link
Contributor

@kutumia kutumia commented Mar 23, 2025

This PR addresses two improvements in the data.atmosphere module and GitHub workflows:


Fixes for #3269 – Broken and Redirected URLs

  • Replaced or commented out 404 URLs in README.md, .Rmd, and .Rd files
  • Updated outdated links to Ameriflux, NEON, PEcAn documentation
  • Added helpful inline comments indicating previous link status

Fixes for #3273 – GitHub Labeler Improvements

  • Refactored .github/labeler.yml to include:
    • Organized label structure (e.g., Docs/User, Scripts/R)
    • More accurate file pattern matching for automated PR labeling

These changes improve:

  • User experience with working documentation links
  • Contributor workflow through more accurate PR labels
  • CRAN compliance and GSoC project hygiene

Fixes: #3269
Fixes: #3273

@kutumia kutumia mentioned this pull request Mar 23, 2025
@kutumia kutumia changed the title Refactor labeler.yml with subcategories for improved PR labeling (#3273) Fix 404 documentation links and improve PR labeling rules (#3269, #3273) Mar 23, 2025
@Sweetdevil144
Copy link
Contributor

I'd say to create another PR for the PR Labeling issue as it would be much easier to trace back to the PR in case something comes up (a good practice though is generally splitting PRs for different isues). Also, would be better to confirm from @allgandalf if your changes fulfill his requirements or not?

@kutumia
Copy link
Contributor Author

kutumia commented Mar 23, 2025

Thanks for the great suggestion — I’ve now split the original PR into two focused ones for better traceability and review:

  1. Broken & outdated URLs fix: #3496 (Fixes CRAN Compliance Issue: Broken and Redirected URLs in PEcAn's data.atmosphere  #3269)

  2. PR labeling improvements: #3497 (Fixes Improve PR Labeling #3273)

This should keep each discussion clean and easier to follow. I’ll also confirm with @allgandalf to ensure the labeling changes meet expectations. Appreciate your guidance!

@infotroph
Copy link
Member

Thanks for the contribution, @kutumia! Do #3496 and #3497 replace this one fully enough it should be closed, or is there more to do here (possibly after those are merged?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve PR Labeling CRAN Compliance Issue: Broken and Redirected URLs in PEcAn's data.atmosphere
3 participants