filebeat: remove usages of inputmon.NewInputRegistry #43862
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
AndersonQ
force-pushed
the
43860-remove-inputmon-NewInputRegistry
branch
from
49c4b20 to
3009090
Compare
AndersonQ
added
release-note:skip
botelastic
bot
removed
the
needs_team
There was a problem hiding this comment.
Copilot reviewed 57 out of 58 changed files in this pull request and generated no comments.
Files not reviewed (1)
- CHANGELOG-developer.next.asciidoc: Language not supported
Comments suppressed due to low confidence (4)
x-pack/filebeat/input/awss3/metrics.go:79
- The un-register call has been removed from the Close() method; please verify that metrics registry cleanup is handled elsewhere to prevent any resource leaks.
m.unregister()
filebeat/input/unix/input.go:144
- Ensure that the v2.Context passed to newInputMetrics includes a valid non-empty ID so that the metrics are properly initialized and not returned as nil.
if ctx.ID == "" {
filebeat/input/netmetrics/udp.go:57
- Confirm that the v2.Context provided to NewUDP includes a non-empty ID to guarantee that the metricset is created as expected.
if ctx.ID == "" {
filebeat/input/netmetrics/tcp.go:55
- Make sure the v2.Context passed to NewTCP contains a valid ID to prevent the metrics from being nil and to ensure proper runtime behavior.
if ctx.ID == "" {
9aaafd3 to
766ced4
Compare
AndersonQ
force-pushed
the
43860-remove-inputmon-NewInputRegistry
branch
from
58f36f1 to
fc8ad51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
How to test this PR locally
Related issues