Skip to content

Bug Report: Darnell dosen't sing when i select him as a player in the chart editor #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks done
Szymonkruk12 opened this issue Sep 21, 2024 · 3 comments · May be fixed by FunkinCrew/funkin.assets#141
Open
2 tasks done

Bug Report: Darnell dosen't sing when i select him as a player in the chart editor #3407

Szymonkruk12 opened this issue Sep 21, 2024 · 3 comments · May be fixed by FunkinCrew/funkin.assets#141
Assignees
@EliteMasterEric
Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: minor bug Involves a minor bug or issue.

Comments

@Szymonkruk12
Copy link

Issue Checklist

  • I have properly named the issue
  • I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

5.0

Context (Provide images, videos, etc.)

No response

Steps to reproduce (or crash logs, errors, etc.)

Playable Darnell only uses idle when pressing a note

2024-09-21.11-44-41.mp4
@Szymonkruk12 Szymonkruk12 added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Sep 21, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Sep 21, 2024

Reproduced.

@EliteMasterEric EliteMasterEric added status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. and removed status: pending triage Awaiting review. labels Sep 22, 2024
@EliteMasterEric EliteMasterEric self-assigned this Sep 22, 2024
@EliteMasterEric
Copy link
Member

I actually found this one myself! Confirmed.

@Lasercar Lasercar linked a pull request Mar 10, 2025 that will close this issue
Open
@Lasercar
Copy link
Contributor

Lasercar commented Mar 10, 2025 •
edited
Loading

This is caused by Darnell's script:

https://github.com/FunkinCrew/funkin.assets/blob/c1899ffbefb9a7c98b030c75a33623431d7ea6ba/preload/scripts/characters/darnell.hxc#L13-L31

The on hit event can only happen if he's the dad character.

I've got a fix for it here: FunkinCrew/funkin.assets#141

It'd be better if there wasn't a need to setup these switches in the character scripts for different note kinds in the first place, so that this can't happen in the future.

@AbnormalPoof AbnormalPoof added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EliteMasterEric EliteMasterEric

Labels
status: pending pull request Dependent on a pull request that is currently awaiting review. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Character doesn't sing notes fix Lasercar/funkin.assets
5 participants
@EliteMasterEric @Lasercar @AbnormalPoof @Szymonkruk12 @Hundrec